Skip to content

ci: fix required-check deadlock (pass-through shim)#26

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/required-check-deadlock-shim
Jun 14, 2026
Merged

ci: fix required-check deadlock (pass-through shim)#26
hyperpolymath merged 1 commit into
mainfrom
fix/required-check-deadlock-shim

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Fix a required-status-check deadlock by converting the path-filtered required job to a pass-through shim (same pattern as echidna#256).

Why

This job is a required status check but its workflow is path-filtered on pull_request, so it never runs (never reports) on PRs that don't touch those paths — branch protection then waits forever and the PR can't merge via normal flow.

Fix

  • Drop the pull_request paths-filter so the job always runs (the required check always reports).
  • A Detect relevant changes step reads the PR's changed files via the GitHub API and gates the heavy steps — real work runs only when the relevant sources change; otherwise it passes through in seconds.
  • push stays scoped to the default branch + paths (post-merge behaviour unchanged); job names preserved so the required contexts still match.

Identified by the 2026-06-14 estate required-check deadlock audit (dev-notes/audits/).

🤖 Generated with Claude Code

Fix a required-status-check deadlock by converting the path-filtered required job to a **pass-through shim** (same pattern as echidna#256).

## Why
This job is a **required** status check but its workflow is path-filtered on `pull_request`, so it never runs (never reports) on PRs that don't touch those paths — branch protection then waits forever and the PR can't merge via normal flow.

## Fix
- Drop the `pull_request` paths-filter so the job **always runs** (the required check always reports).
- A `Detect relevant changes` step reads the PR's changed files via the GitHub API and gates the heavy steps — real work runs only when the relevant sources change; otherwise it passes through in seconds.
- `push` stays scoped to the default branch + paths (post-merge behaviour unchanged); job names preserved so the required contexts still match.

Identified by the 2026-06-14 estate required-check deadlock audit (`dev-notes/audits/`).

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@hyperpolymath
hyperpolymath merged commit 3c16c20 into main Jun 14, 2026
10 of 11 checks passed
@hyperpolymath
hyperpolymath deleted the fix/required-check-deadlock-shim branch June 14, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant